fix: structural tests find call site instead of method definition#453
fix: structural tests find call site instead of method definition#453
Conversation
ExtractMethod('ForceCompleteProcessingAsync') matched the first
occurrence in the file — a call site added in PR #449 — instead of
the method definition. The extracted block was the caller's method,
which doesn't contain INV-1 fields, timer cancellation, or the
IsProcessing guard.
Fix: use 'Task ForceCompleteProcessingAsync' as the search signature
to match the method definition, not call sites.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🤖 Multi-Model Code Review — PR #453fix: structural tests find call site instead of method definition Fix CorrectnessAll 3 models confirm: the fix is correct and non-regressive. Consensus Findings🟡 MODERATE —
|
…reWeen#453) ## Problem 3 tests in `SessionStabilityTests` fail on CI ([run](https://github.com/PureWeen/PolyPilot/actions/runs/23723487548/job/69102600929)): - `ForceCompleteProcessing_ClearsAllInv1Fields` - `ForceCompleteProcessing_CancelsTimersBeforeUiThreadWork` - `ForceCompleteProcessing_SkipsIfNotProcessing` `ExtractMethod(source, "ForceCompleteProcessingAsync")` matched the first occurrence in the file — a **call site** added in PR PureWeen#449 — instead of the method definition. The extracted block was the caller's method body, which doesn't contain the INV-1 fields, timer cancellation, or IsProcessing guard the tests expect. ## Fix Use `"Task ForceCompleteProcessingAsync"` as the search signature so `ExtractMethod` matches the method definition, not call sites. ## Verification All 3,031 tests pass locally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 participant
Problem
3 tests in
SessionStabilityTestsfail on CI (run):ForceCompleteProcessing_ClearsAllInv1FieldsForceCompleteProcessing_CancelsTimersBeforeUiThreadWorkForceCompleteProcessing_SkipsIfNotProcessingExtractMethod(source, "ForceCompleteProcessingAsync")matched the first occurrence in the file — a call site added in PR #449 — instead of the method definition. The extracted block was the caller's method body, which doesn't contain the INV-1 fields, timer cancellation, or IsProcessing guard the tests expect.Fix
Use
"Task ForceCompleteProcessingAsync"as the search signature soExtractMethodmatches the method definition, not call sites.Verification
All 3,031 tests pass locally.